/blackbox_exporter

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added headers support #32

Closed
wants to merge 5 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Dnile @brian-brazil @zerthimon
@Dnile

Dnile commented Feb 8, 2016

added headers support in the blackbox_exporter config yml,
Headers located under HTTPProbe in http.go.

updated readme accordingly.
Show outdated Hide outdated README.md
Show outdated Hide outdated http.go
@brian-brazil

This comment has been minimized.

Show comment
Hide comment
@brian-brazil

brian-brazil Feb 8, 2016

Member

Can you add a unittest please?
Member

brian-brazil commented Feb 8, 2016

Can you add a unittest please?
@Dnile

This comment has been minimized.

Show comment
Hide comment
@Dnile

Dnile Feb 8, 2016

thanks for the comments, fixed

Dnile commented Feb 8, 2016

thanks for the comments, fixed

@juliusv juliusv referenced this pull request Jun 11, 2016

Closed

Send arbitrary extra headers when scraping #1724

@zerthimon

This comment has been minimized.

Show comment
Hide comment
@zerthimon

zerthimon Jun 30, 2016

+1

zerthimon commented Jun 30, 2016

+1
@brian-brazil

This comment has been minimized.

Show comment
Hide comment
@brian-brazil

brian-brazil Jun 30, 2016

Member

Can you squash your commits and fix the conflict?
Member

brian-brazil commented Jun 30, 2016

Can you squash your commits and fix the conflict?
@brian-brazil

This comment has been minimized.

Show comment
Hide comment
@brian-brazil

brian-brazil Jul 26, 2016

Member

Header support was added in another PR.
Member

brian-brazil commented Jul 26, 2016

Header support was added in another PR.

@brian-brazil brian-brazil closed this Jul 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment