CrLf option for newline #703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Fischer <bjoern.fischer@inovex.de>
|
Hmm, couldn't you put a |
|
To my surprise that works. Should we at least change the SMTP examples to make them compliant to spec? |
|
That sounds like a good idea. |
|
Closing in favor of #706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most internet protocols require
CRLFfor a newline. For example, for SMTP see https://tools.ietf.org/html/rfc2821#section-4.1.1The blackbox exporter is only sending
LF, which is accepted by some servers (e.g. Postfix) but not by others (e.g. Exchange). This PR adds an option to sendCRLF. I've set it to false by default for backwards compatibility (although it should probably be enabled in most cases).