Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated NewBuildInfoCollector API #1000

Merged
merged 2 commits into from Mar 17, 2022
Merged

Fix deprecated NewBuildInfoCollector API #1000

merged 2 commits into from Mar 17, 2022

Conversation

alissa-tung
Copy link
Contributor

@alissa-tung alissa-tung commented Mar 15, 2022

  1. Update examples/random/main.go: prometheus.NewBuildInfoCollector is deprecated. Use collectors.NewBuildInfoCollector instead.

Copy link
Member

@bwplotka bwplotka left a comment

Nice!

But can we remove main binary from this PR? I think it was added by accident.

@alissa-tung
Copy link
Contributor Author

alissa-tung commented Mar 16, 2022

Nice!

But can we remove main binary from this PR? I think it was added by accident.

sorry i gonna give a fix

@alissa-tung alissa-tung requested a review from bwplotka Mar 16, 2022
Copy link
Member

@kakkoyun kakkoyun left a comment

LGTM

@kakkoyun
Copy link
Member

kakkoyun commented Mar 16, 2022

@bwplotka Feel free to merge :)

@kakkoyun
Copy link
Member

kakkoyun commented Mar 16, 2022

@alissa-tung Would you mind maybe adding comment changes in this PR as well here? #918

@alissa-tung
Copy link
Contributor Author

alissa-tung commented Mar 16, 2022

@alissa-tung Would you mind maybe adding comment changes in this PR as well here? #918

done

@kakkoyun
Copy link
Member

kakkoyun commented Mar 16, 2022

@alissa-tung By any chance you forgot to push? I don't see the changes

Update `examples/random/main.go`:
  `prometheus.NewBuildInfoCollector` is deprecated. Use `collectors.NewBuildInfoCollector` instead.

Signed-off-by: alissa-tung <alissa-tung@outlook.com>
@alissa-tung
Copy link
Contributor Author

alissa-tung commented Mar 16, 2022

@alissa-tung By any chance you forgot to push? I don't see the changes

yes, sorry :(

@kakkoyun
Copy link
Member

kakkoyun commented Mar 16, 2022

@alissa-tung By any chance you forgot to push? I don't see the changes

yes, sorry :(

Still the same :/

@alissa-tung
Copy link
Contributor Author

alissa-tung commented Mar 16, 2022

@alissa-tung By any chance you forgot to push? I don't see the changes

yes, sorry :(

Still the same :/

https://github.com/prometheus/client_golang/pull/1000/commits

i though there are some commit message comment here 🤔 im not native English speaker, im afraid that there is something i misunderstood

Signed-off-by: alissa-tung <alissa-tung@outlook.com>

Co-authored-by: Cruise_Hua <zlh429375251@qq.com>
@alissa-tung
Copy link
Contributor Author

alissa-tung commented Mar 16, 2022

is ffd6362 work as expected?

@kakkoyun
Copy link
Member

kakkoyun commented Mar 16, 2022

is ffd6362 work as expected?

Yes, thanks 🙏

Copy link
Member

@kakkoyun kakkoyun left a comment

LGTM

@kakkoyun kakkoyun merged commit fe8d1e1 into prometheus:main Mar 17, 2022
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants