Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When prefix is empty, no more dots should be written #1005

Merged
merged 1 commit into from Mar 17, 2022

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Mar 17, 2022

Close #1004

Signed-off-by: zhijian <djx@juicedata.io>
Copy link
Member

@bwplotka bwplotka left a comment

Great job, thanks!

)
var wantWithPrefix string
if tc.prefix == "" {
wantWithPrefix = strings.ReplaceAll(want, "%s.", "")
Copy link
Member

@bwplotka bwplotka Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sneaky, but makes sense. (:

@bwplotka bwplotka merged commit 36b47eb into prometheus:main Mar 17, 2022
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When prefix is empty, no more dots should be written
2 participants