Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor apiClientImpl.DoGetFallback #1021

Merged
merged 1 commit into from Apr 12, 2022

Conversation

dohnto
Copy link
Contributor

@dohnto dohnto commented Apr 7, 2022

Make apiClientImpl.DoGetFallback more idiomatic and efficient:

  • Save result of args.Encode() operation as it might be used 2 times in
    the function and due to looping and sorting it might be heavy.
  • Follow line-of-sight practise and therefore simplify the code.

Make apiClientImpl.DoGetFallback more idiomatic and efficient:
 * Save result of args.Encode() operation as it might be used 2 times in
   the function and due to looping and sorting it might be heavy.
 * Follow line-of-sight practise and therefore simplify the code.

Signed-off-by: Tomáš Dohnálek <dohnto@gmail.com>
@dohnto dohnto force-pushed the dohnto/line-of-sight branch from 4bf68a2 to 40e54a7 Compare Apr 7, 2022
api/prometheus/v1/api.go Show resolved Hide resolved
Copy link
Member

@kakkoyun kakkoyun left a comment

LGTM 👍 Thanks for the contribution.

I'll go ahead and merge it since we have tests for this method and there doesn't seem to any regressions present.

@kakkoyun kakkoyun merged commit 130da3b into prometheus:main Apr 12, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants