Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push: Add PushContext and AddContext to Pusher #1028

Merged
merged 1 commit into from Apr 12, 2022

Conversation

tatsuhiro-t
Copy link
Contributor

@tatsuhiro-t tatsuhiro-t commented Apr 12, 2022

Add PushContext and AddContext to Pusher, which are context-aware
version of Push and Add respectively. They give a caller the ability
to cancel an HTTP request.

Add PushContext and AddContext to Pusher, which are context-aware
version of Push and Add respectively.  They give a caller the ability
to cancel an HTTP request.

Signed-off-by: Tatsuhiro Tsujikawa <ttsujika@zlab.co.jp>
Copy link
Member

@kakkoyun kakkoyun left a comment

LGTM. It seems like a needed addition.

Thanks for taking care of it.

@kakkoyun kakkoyun requested a review from bwplotka Apr 12, 2022
Copy link
Member

@bwplotka bwplotka left a comment

Thanks!

@bwplotka bwplotka merged commit 0bab4fd into prometheus:main Apr 12, 2022
8 checks passed
@tatsuhiro-t tatsuhiro-t deleted the push-context branch Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants