Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -Inf buckets from go collector histograms #1049

Merged
merged 3 commits into from May 13, 2022

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented May 12, 2022

Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com

Fixes #981 #995

@kakkoyun kakkoyun requested review from beorn7 and bwplotka May 12, 2022
Copy link
Member

@bwplotka bwplotka left a comment

...and cardinality win 💪🏽

Thanks!

prometheus/collectors/go_collector_latest_test.go Outdated Show resolved Hide resolved
kakkoyun and others added 2 commits May 12, 2022
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@kakkoyun kakkoyun merged commit 35c82f2 into prometheus:main May 13, 2022
7 checks passed
@kakkoyun kakkoyun deleted the fix_histogram_nan branch May 13, 2022
kakkoyun added a commit that referenced this issue May 13, 2022
* Remove -Inf buckets from go collector histograms

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Update prometheus/collectors/go_collector_latest_test.go

Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Simplify

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants