Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exemplar labels limit from 64 to 128 #1091

Merged
merged 1 commit into from Jul 19, 2022

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Jul 19, 2022

In line with the OpenMetrics spec:

The combined length of the label names and values of an Exemplar's LabelSet MUST NOT exceed 128 UTF-8 character code points

https://github.com/OpenObservability/OpenMetrics/blob/98ae26c87b/specification/OpenMetrics.md#exemplars

I suspect this number changed since the discussion in #706, but I can't see that change in the git history of the spec.

In line with the OpenMetrics spec:
"The combined length of the label names and values of an Exemplar's
LabelSet MUST NOT exceed 128 UTF-8 character code points"

https://github.com/OpenObservability/OpenMetrics/blob/98ae26c87b/specification/OpenMetrics.md#exemplars

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@kakkoyun
Copy link
Member

kakkoyun commented Jul 19, 2022

@beorn7 Do you have any comments on this?

@beorn7
Copy link
Member

beorn7 commented Jul 19, 2022

This looks fine.

@kakkoyun kakkoyun requested a review from bwplotka Jul 19, 2022
@kakkoyun kakkoyun merged commit ba4a543 into prometheus:main Jul 19, 2022
6 checks passed
@bwplotka
Copy link
Member

bwplotka commented Jul 27, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants