Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ioutil #1096

Merged
merged 1 commit into from Aug 2, 2022
Merged

Remove ioutil #1096

merged 1 commit into from Aug 2, 2022

Conversation

inosato
Copy link
Contributor

@inosato inosato commented Jul 29, 2022

ioutil is deprecated from go1.16 (ref: https://go.dev/doc/go1.16#ioutil).
So removed them.

Signed-off-by: inosato si17_21@yahoo.co.jp

Signed-off-by: inosato <si17_21@yahoo.co.jp>
@bwplotka
Copy link
Member

bwplotka commented Aug 2, 2022

Lol. I did not know that, well spotted! (still was using ioutil everywhere).

Perhaps we could set up faillint to avoid that problem in future https://github.com/fatih/faillint

Copy link
Member

@bwplotka bwplotka left a comment

LGTM, thanks

@bwplotka bwplotka merged commit 44c2c4d into prometheus:main Aug 2, 2022
6 checks passed
@inosato inosato deleted the replace-ioutil branch Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants