Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and support 1.19 #1160

Merged
merged 2 commits into from Nov 7, 2022
Merged

Test and support 1.19 #1160

merged 2 commits into from Nov 7, 2022

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Nov 7, 2022

Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com

Fixes #1135

  • Add update tests for new Go 1.19 metrics
  • Format files using the latest formatter

@kakkoyun kakkoyun changed the title Add update tests for new Go 1.19 metrics Test and support 1.19 Nov 7, 2022
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏽

@bwplotka bwplotka merged commit 870469e into prometheus:main Nov 7, 2022
7 checks passed
@kakkoyun kakkoyun deleted the test_golang_119 branch November 8, 2022 03:41
@bboreham
Copy link
Contributor

bboreham commented Dec 8, 2022

Did we really need all the spacing changes in comments? This makes it very hard to review diffs when updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestGoCollectorAllowList tests fail in v1.13.0 with Go 1.19
3 participants