From 382efefe84cc8332c40f5d14423ba97059ffab49 Mon Sep 17 00:00:00 2001 From: Filip Petkovski Date: Tue, 7 Oct 2025 14:59:35 +0200 Subject: [PATCH] bug(remote_write): Fix compression buffer pooling The compressed buffer is released before the request is made, which leads to corrupted remote-write payloads being sent to the target. Signed-off-by: Filip Petkovski --- exp/api/remote/remote_api.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exp/api/remote/remote_api.go b/exp/api/remote/remote_api.go index cf912249a..161312900 100644 --- a/exp/api/remote/remote_api.go +++ b/exp/api/remote/remote_api.go @@ -242,7 +242,7 @@ func (r *API) Write(ctx context.Context, msgType WriteMessageType, msg any) (_ W return WriteResponseStats{}, fmt.Errorf("compressing %w", err) } r.bufPool.Put(buf) - r.bufPool.Put(comprBuf) + defer r.bufPool.Put(comprBuf) // Since we retry writes we need to track the total amount of accepted data // across the various attempts.