Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build against GopherJS #897

Merged
merged 3 commits into from Aug 5, 2022
Merged

Conversation

paralin
Copy link
Contributor

@paralin paralin commented Aug 4, 2021

When building against GopherJS, ThreadCreateProfile and Getpid are not available.

Return 1 to shim the functions.

Fixes "gopherjs build ./..."

Copy link
Member

@bwplotka bwplotka left a comment

Amazing, thank you!

Do you mind adding CI job for GopherJS? 🤗

Also current CI is not passing, somehow stuck...

Also it's interesting usage.. How you gather metrics from browser applications?

@kakkoyun
Copy link
Member

kakkoyun commented Mar 16, 2022

@paralin Do you want to continue working on this PR?

@paralin
Copy link
Contributor Author

paralin commented Mar 16, 2022

Yes, I'm using it. @bwplotka I collect metrics from the browser using the stack at https://github.com/aperturerobotics - not all of it is open source yet :)

Copy link
Member

@bwplotka bwplotka left a comment

This looks great then! Thanks. Can you rebase to main and make sure we test against newest golang? 🤗

@paralin
Copy link
Contributor Author

paralin commented Mar 18, 2022

@bwplotka rebased

@paralin
Copy link
Contributor Author

paralin commented Mar 18, 2022

BTW, it's not running the CI: "First-time contributors need a maintainer to approve running workflows."

@stale
Copy link

stale bot commented Jun 4, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jun 4, 2022
@stale stale bot closed this Jun 11, 2022
@kakkoyun kakkoyun reopened this Jun 12, 2022
@stale stale bot removed the stale label Jun 12, 2022
@kakkoyun
Copy link
Member

kakkoyun commented Jun 17, 2022

@paralin It seems like you need to update the build tags for 1.18

And it worths rebasing since we bumped the minimum required version to 1.17 #1062

@kakkoyun kakkoyun added this to the v1.13.0 milestone Jun 17, 2022
@bwplotka
Copy link
Member

bwplotka commented Aug 2, 2022

ping @paralin (:

@bwplotka
Copy link
Member

bwplotka commented Aug 2, 2022

We might want to add CI too, otherwise it's easy to break your build in next change....

@kakkoyun
Copy link
Member

kakkoyun commented Aug 2, 2022

It would be nice if we can push this across the finish line @paralin. Not to get you stressed about it, but we have a planned release at the end of the week. However, if you can't make it. It's perfectly fine, we can have it in the next release.

When building against GopherJS, ThreadCreateProfile and Getpid are not
available.

Return 1 to shim the functions.

Signed-off-by: Christian Stewart <christian@paral.in>
@paralin
Copy link
Contributor Author

paralin commented Aug 4, 2022

Rebased & build tested

kakkoyun added 2 commits Aug 5, 2022
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Move build tags for licence header checks

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Copy link
Member

@kakkoyun kakkoyun left a comment

LGTM

@kakkoyun kakkoyun merged commit d44fbbe into prometheus:main Aug 5, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants