Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: support wal replay status api #944

Merged
merged 1 commit into from Jan 5, 2022

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 5, 2021

Signed-off-by: Ben Ye ben.ye@bytedance.com

Support the WAL Replay Status API https://prometheus.io/docs/prometheus/latest/querying/api/#wal-replay-stats.

From the document, there should be another field state:

$ curl http://localhost:9090/api/v1/status/walreplay
{
  "status": "success",
  "data": {
    "min": 2,
    "max": 5,
    "current": 40,
    "state": "in progress"
  }
}

But I cannot find it from the prometheus code https://github.com/prometheus/prometheus/blob/main/web/api/v1/api.go#L1375.

Signed-off-by: Ben Ye <ben.ye@bytedance.com>
@yeya24
Copy link
Contributor Author

yeya24 commented Jan 5, 2022

Anyone could help with reviewing this? @beorn7 @kakkoyun Thank you!

@kakkoyun kakkoyun changed the title support wal replay status api API: support wal replay status api Jan 5, 2022
Copy link
Member

@kakkoyun kakkoyun left a comment

LGTM

@kakkoyun kakkoyun merged commit e6e54e8 into prometheus:master Jan 5, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants