Reduce granularity of histogram buckets for Go 1.17 collector #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bwplotka
approved these changes
Jan 25, 2022
| @@ -37,3 +37,5 @@ var expectedRuntimeMetrics = map[string]string{ | |||
| "/sched/goroutines:goroutines": "go_sched_goroutines_goroutines", | |||
| "/sched/latencies:seconds": "go_sched_latencies_seconds", | |||
| } | |||
|
|
|||
| const expectedRuntimeMetricsCardinality = 79 | |||
kakkoyun
reviewed
Jan 27, 2022
LGTM. Thanks @mknyszek for taking care of this.
As @bwplotka, it would be nice add more explanation comments, it'd be easier for us to maintain in the long run.
Also we might consider handling #967 (comment) as well before the next patch release. Not necessarily as part of this PR though.
The Go runtime/metrics package currently exports extremely granular histograms. Exponentially bucket any histogram with unit "seconds" or "bytes" instead to dramatically reduce the number of buckets, and thus the number of metrics. This change also adds a test to check for expected cardinality to prevent cardinality surprises in the future. Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
kakkoyun
pushed a commit
that referenced
this issue
May 13, 2022
The Go runtime/metrics package currently exports extremely granular histograms. Exponentially bucket any histogram with unit "seconds" or "bytes" instead to dramatically reduce the number of buckets, and thus the number of metrics. This change also adds a test to check for expected cardinality to prevent cardinality surprises in the future. Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The Go runtime/metrics package currently exports extremely granular
histograms. Exponentially bucket any histogram with unit "seconds"
or "bytes" instead to dramatically reduce the number of buckets, and
thus the number of metrics.
This change also adds a test to check for expected cardinality to
prevent cardinality surprises in the future.
Fixes #967
Signed-off-by: Michael Anthony Knyszek mknyszek@google.com