API client: make http reads more efficient #976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Replace
io.ReadAll
withbytes.Buffer.ReadFrom
.Both need to resize a buffer until they have finished reading; the former increases by 1.25x each time while the latter uses 2x.
(I considered using
ContentLength
to size the buffer, but empirically Prometheus does not set it on larger responses.)Also added a benchmark to demonstrate the benefit: