Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Set minimal support version of go to 1.15 #980

Merged
merged 1 commit into from Feb 3, 2022

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Jan 31, 2022

As requested in prometheus/common#353 (comment)

Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@beorn7
Copy link
Member

beorn7 commented Feb 2, 2022

Since this library is so widely used, we usually only bump the version requirement if we really have to (i.e. because there is code requiring the more recent version). Supporting the last two or three Go versions is a minimal requirement (i.e. we would use build tags and such for features requiring newer Go versions). As long as older Go versions still work without additional hassle, we should IMHO keep the support.

@mrueg
Copy link
Contributor Author

mrueg commented Feb 2, 2022

Thanks for the feedback and I probably should have explained this better here. Unfortunately I believe it needs to be raised due to the x/net dependency upgraded in prometheus/common#348 to mitigate a potential vuln. With the upgraded x/net, prometheus/common doesn't seem to work with earlier versions of go than 1.15.

@roidelapluie and @SuperQ can chime in, in which order the change should enter as this repo also depends on prometheus/common.

@beorn7
Copy link
Member

beorn7 commented Feb 2, 2022

OK, a security update of a dependency, thereby having dependencies requiring newer Go versions, sounds like a good reason.

That context wasn't clear to me.

@mrueg
Copy link
Contributor Author

mrueg commented Feb 2, 2022

Apologies again for not providing that context earlier.
Still not sure how releasing both repos usually works because of the circular dependency. I guess client_golang starts first, then common depends on the new version and then client_golang has another release?

SuperQ
SuperQ approved these changes Feb 2, 2022
Copy link
Member

@SuperQ SuperQ left a comment

LGTM

@SuperQ
Copy link
Member

SuperQ commented Feb 2, 2022

I'm not sure we need to cut a release for these changes.

@SuperQ
Copy link
Member

SuperQ commented Feb 2, 2022

I've updated the branch protection rules to reflect this change.

Copy link
Member

@kakkoyun kakkoyun left a comment

LGTM

Thanks for taking care of it.

@kakkoyun kakkoyun merged commit 5ac1e92 into prometheus:main Feb 3, 2022
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants