From 8df1e9020e392f3adb44ab6e154b70825942c90a Mon Sep 17 00:00:00 2001 From: Stanislav Savulchik Date: Sun, 7 Jan 2018 17:13:54 +0700 Subject: [PATCH] Fix bug in CollectorRegistry#collectorNames method The switch statement was missing breaks for SUMMARY and HISTOGRAM cases. Due to this bug wrong and duplicate collector names are produced for summaries and histograms. --- .../src/main/java/io/prometheus/client/CollectorRegistry.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/simpleclient/src/main/java/io/prometheus/client/CollectorRegistry.java b/simpleclient/src/main/java/io/prometheus/client/CollectorRegistry.java index 25baba669..a044d4e65 100644 --- a/simpleclient/src/main/java/io/prometheus/client/CollectorRegistry.java +++ b/simpleclient/src/main/java/io/prometheus/client/CollectorRegistry.java @@ -109,10 +109,13 @@ private List collectorNames(Collector m) { names.add(family.name + "_count"); names.add(family.name + "_sum"); names.add(family.name); + break; case HISTOGRAM: names.add(family.name + "_count"); names.add(family.name + "_sum"); names.add(family.name + "_bucket"); + names.add(family.name); + break; default: names.add(family.name); }