From 6ba7e8c6f6158eae6ef871c2fa1289bbd8df8907 Mon Sep 17 00:00:00 2001 From: Dzmitry Lazerka Date: Sat, 2 Feb 2019 15:49:44 -0800 Subject: [PATCH] Don't throw NPE if `.help()` wasn't called See issue #457 Signed-off-by: Dzmitry Lazerka --- .../src/main/java/io/prometheus/client/SimpleCollector.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simpleclient/src/main/java/io/prometheus/client/SimpleCollector.java b/simpleclient/src/main/java/io/prometheus/client/SimpleCollector.java index ed8c5c8a0..a70d5d4e7 100644 --- a/simpleclient/src/main/java/io/prometheus/client/SimpleCollector.java +++ b/simpleclient/src/main/java/io/prometheus/client/SimpleCollector.java @@ -162,7 +162,7 @@ protected SimpleCollector(Builder b) { } fullname = name; checkMetricName(fullname); - if (b.help.isEmpty()) throw new IllegalStateException("Help hasn't been set."); + if (b.help != null && b.help.isEmpty()) throw new IllegalStateException("Help hasn't been set."); help = b.help; labelNames = Arrays.asList(b.labelNames);