Skip to content

Summary based on HdrHistogram #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lavrov wants to merge 4 commits into from
Closed

Summary based on HdrHistogram #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d4a28b
Copy code of HdrHistogram from https://github.com/HdrHistogram/HdrHis…
lavrov Nov 30, 2020
b7b696a
Implement Summary with HdrHistogram
lavrov Nov 30, 2020
2592f88
Compile with 1.6 java
lavrov Dec 1, 2020
546dc65
Reduce diff in SummaryTests
lavrov Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion benchmark/src/main/java/io/prometheus/benchmark/SummaryBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,14 @@ public class SummaryBenchmark {

io.prometheus.client.metrics.Summary prometheusSummary;
io.prometheus.client.metrics.Summary.Child prometheusSummaryChild;

io.prometheus.client.Summary prometheusSimpleSummary;
io.prometheus.client.Summary.Child prometheusSimpleSummaryChild;
io.prometheus.client.Summary prometheusSimpleSummaryNoLabels;
io.prometheus.client.Summary prometheusSimpleSummaryQuantiles;
io.prometheus.client.Summary.Child prometheusSimpleSummaryQuantilesChild;
io.prometheus.client.Summary prometheusSimpleSummaryQuantilesNoLabels;

io.prometheus.client.Histogram prometheusSimpleHistogram;
io.prometheus.client.Histogram.Child prometheusSimpleHistogramChild;
io.prometheus.client.Histogram prometheusSimpleHistogramNoLabels;
Expand All @@ -49,10 +54,25 @@ public void setup() {
.help("some description..")
.create();

prometheusSimpleSummaryQuantiles = io.prometheus.client.Summary.build()
.name("name")
.help("some description..")
.labelNames("some", "group")
.quantile(0.5).quantile(0.9).quantile(0.95).quantile(0.99)
.create();
prometheusSimpleSummaryQuantilesChild = prometheusSimpleSummaryQuantiles.labels("test", "group");

prometheusSimpleSummaryQuantilesNoLabels = io.prometheus.client.Summary.build()
.name("name")
.help("some description..")
.quantile(0.5).quantile(0.9).quantile(0.95).quantile(0.99)
.create();

prometheusSimpleHistogram = io.prometheus.client.Histogram.build()
.name("name")
.help("some description..")
.labelNames("some", "group").create();
.labelNames("some", "group")
.create();
prometheusSimpleHistogramChild = prometheusSimpleHistogram.labels("test", "group");

prometheusSimpleHistogramNoLabels = io.prometheus.client.Histogram.build()
Expand Down Expand Up @@ -99,6 +119,27 @@ public void prometheusSimpleSummaryNoLabelsBenchmark() {
prometheusSimpleSummaryNoLabels.observe(1);
}

@Benchmark
@BenchmarkMode({Mode.AverageTime})
@OutputTimeUnit(TimeUnit.NANOSECONDS)
public void prometheusSimpleSummaryQuantilesBenchmark() {
prometheusSimpleSummaryQuantiles.labels("test", "group").observe(1);
}

@Benchmark
@BenchmarkMode({Mode.AverageTime})
@OutputTimeUnit(TimeUnit.NANOSECONDS)
public void prometheusSimpleSummaryQuantilesChildBenchmark() {
prometheusSimpleSummaryQuantilesChild.observe(1);
}

@Benchmark
@BenchmarkMode({Mode.AverageTime})
@OutputTimeUnit(TimeUnit.NANOSECONDS)
public void prometheusSimpleSummaryQuantilesNoLabelsBenchmark() {
prometheusSimpleSummaryQuantilesNoLabels.observe(1);
}

@Benchmark
@BenchmarkMode({Mode.AverageTime})
@OutputTimeUnit(TimeUnit.NANOSECONDS)
Expand Down
293 changes: 0 additions & 293 deletions simpleclient/src/main/java/io/prometheus/client/CKMSQuantiles.java
View file
Open in desktop

This file was deleted.

Loading