New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubygems.org contains bad version of prometheus client model. #29

Closed
xtreme-andrew-su opened this Issue Jan 3, 2019 · 12 comments

Comments

Projects
None yet
3 participants
@xtreme-andrew-su
Copy link
Contributor

xtreme-andrew-su commented Jan 3, 2019

The version published to rubygems.org is not the actual prometheus client model gem. It contains code for "hello world".

I propose two options:

  • Publish the actual gem even if it is not maintained anymore
  • Remove the current gem from rubygems.org and update the documentation to mention deprecation and suggest alternatives.

https://rubygems.org/gems/prometheus-client-model/versions/1.0.0

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Jan 5, 2019

@grobie do you have context on this issue?

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Jan 8, 2019

@grobie are you able to comment on this?

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Jan 9, 2019

I don't know who has uploaded that Gem, that's not me and I have never heard of that handle. I don't think we can do much here, besides asking that person to take down that gem.

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Jan 10, 2019

@grobie In the README.md for Ruby, thele is a line gem install prometheus-client-model. Doesn't that install the Gem mentioned by @xtreme-andrew-su ? You added the README.md in 775af94 .

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Jan 13, 2019

Yes it does. IIRC correctly this was in preparation for adding protobuf support to client ruby. We can remove the readme or reach out that user asking them to delete that stub gem so that we can publish the actual gem.

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Jan 15, 2019

Hmm, how to contact the owner of a gem on rubygems.org? For now, I'll remove the misleading line.

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Jan 15, 2019

@xtreme-andrew-su I'm closing this now as the misleading install instructions have been removed. If you know a way to contact the owner of the gem, feel free to encourage them to update (or remove) it.

@xtreme-andrew-su

This comment has been minimized.

Copy link
Contributor Author

xtreme-andrew-su commented Jan 17, 2019

@beorn7 I took a look at the other gems that person has uploaded. It looks like they're just name squatting .. most if not all are "hello world". May need to contact the maintainers of rubygems.org or file an abuse claim.

@xtreme-andrew-su

This comment has been minimized.

Copy link
Contributor Author

xtreme-andrew-su commented Jan 17, 2019

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Jan 18, 2019

Many thanks @xtreme-andrew-su . Since you linked this issue there, I guess we won't need to chime in. But if rubygems.org requires my direct intervention, I'll happily do so.

@xtreme-andrew-su

This comment has been minimized.

Copy link
Contributor Author

xtreme-andrew-su commented Jan 21, 2019

@beorn7 The current owner of the gem has responded to the ticket. I've posted an update requesting to transfer ownership to you at the email specified in your github profile. Please reply to the ticket on rubygems.org or reach out to the owner if that info is incorrect.

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Jan 21, 2019

I would actually prefer to remove the gem altogether. The Ruby client of Prometheus doesn't support protobuf, and since even the Prometheus server dropped protobuf support (much to my dismay), there are no plans to add it ever. Use cases for this gem would be quite niche at best, and I don't think we should encourage its usage at the moment by providing a gem. (Nor do I want to invest efforts in maintaining it.) For power users that need it for some reason, there is still the code in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment