Fix lint related to assigned but unused variables #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_core.py
Outdated
There was a problem hiding this comment.
This changes the test
There was a problem hiding this comment.
It does, but the test still fails if the change from commit e5e73e5 is reversed. It's really testing the constructor not recorded values, which is covered by TestHistogram.test_histogram.
Is there a better way of asserting "this isn't a _LabelWrapper that needs labels() called before using"? I don't really want to use isinstance().
There was a problem hiding this comment.
You could not assign to a variable
There was a problem hiding this comment.
Okay, I wanted a better assertion but if you're fine with just checking the registry.
Resolves F841. Also improves several tests to assert on relevant behaviours. Signed-off-by: Martin Packman <martin@zegami.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves F841.
Also improves several tests to assert on relevant behaviours.