From f19629ec27f5e95ac6f08ad39ddacc1210f0f51f Mon Sep 17 00:00:00 2001 From: Chris Sinjakli Date: Thu, 27 Jun 2024 18:03:42 +0100 Subject: [PATCH 1/2] Pin `tins` dependency for JRuby 9.1 The latest version of `tins` adds a dependency on `bigdecimal`, which causes JRuby to fetch and build it rather than using its built-in version. This fails on JRuby 9.1, so we need to handle that version specifically. This gets CI back to green. Signed-off-by: Chris Sinjakli --- Gemfile | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index ffd82038..b02dabb5 100644 --- a/Gemfile +++ b/Gemfile @@ -10,5 +10,14 @@ group :test do gem 'rake' gem 'rspec' gem 'term-ansicolor' - gem 'tins' + # The latest version of `tins` adds a dependency on `bigdecimal`, which + # causes JRuby to fetch and build it rather than using its built-in version. + # This fails on JRuby 9.1, so we need to handle that version specifically. + # + # TODO: Remove this when we drop JRuby 9.1 from the build matrix + if defined?(JRUBY_VERSION) && Gem::Version.new(JRUBY_VERSION) <= Gem::Version.new("9.2.0") + gem 'tins', '<= 1.32.1' + else + gem 'tins' + end end From b307e1d59957e3167f107f16f9e4c97809ec3825 Mon Sep 17 00:00:00 2001 From: Chris Sinjakli Date: Fri, 28 Jun 2024 10:59:40 +0100 Subject: [PATCH 2/2] yeet term-ansicolor and tins --- Gemfile | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/Gemfile b/Gemfile index b02dabb5..8b6fee68 100644 --- a/Gemfile +++ b/Gemfile @@ -9,15 +9,4 @@ group :test do gem 'rack-test' gem 'rake' gem 'rspec' - gem 'term-ansicolor' - # The latest version of `tins` adds a dependency on `bigdecimal`, which - # causes JRuby to fetch and build it rather than using its built-in version. - # This fails on JRuby 9.1, so we need to handle that version specifically. - # - # TODO: Remove this when we drop JRuby 9.1 from the build matrix - if defined?(JRUBY_VERSION) && Gem::Version.new(JRUBY_VERSION) <= Gem::Version.new("9.2.0") - gem 'tins', '<= 1.32.1' - else - gem 'tins' - end end