Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed length millisecond timestamp format for logs #172

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
2 participants
@sylr
Copy link
Contributor

commented Feb 17, 2019

Port prometheus/prometheus#5225 over to common

Show resolved Hide resolved promlog/log.go Outdated

@sylr sylr force-pushed the sylr:log-timestamp branch 2 times, most recently from 7a212df to 0822b6e Feb 18, 2019

var (
timestampFormat = log.TimestampFormat(
func() time.Time { return time.Now().UTC() },
"2006-01-02T15:04:05.000Z07:00",

This comment has been minimized.

Copy link
@brian-brazil

brian-brazil Feb 19, 2019

Member

You should probably add a comment as to how this is different to the usual

This comment has been minimized.

Copy link
@sylr

sylr Feb 19, 2019

Author Contributor

Done

Use fixed length millisecond timestamp format for logs
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>

@sylr sylr force-pushed the sylr:log-timestamp branch from 0822b6e to b4e87eb Feb 19, 2019

@brian-brazil brian-brazil merged commit 7a3416f into prometheus:master Feb 19, 2019

2 checks passed

DCO DCO
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brian-brazil

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.