Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `route.Param` panic on something else than a string #183

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
2 participants
@beorn7
Copy link
Member

commented Apr 2, 2019

As discussed in #181, the values in the context should always be
strings, but this makes sure of it, while the previous implementation
would return an empty string if somehow a non-string value made it
into the context.

This got accidentally steamrolled in the merge of #181. Not a big deal, but now that we have discussed it at length, let's also have it.

Make `route.Param` panic on something else than a string
As discussed in #181, the values in the context should always be
strings, but this makes sure of it, while the previous implementation
would return an empty string if somehow a non-string value made it
into the context.

Signed-off-by: Bjoern Rabenstein <bjoern@rabenste.in>

@beorn7 beorn7 requested a review from brian-brazil Apr 2, 2019

@brian-brazil brian-brazil merged commit 5df5c82 into master Apr 2, 2019

3 checks passed

DCO DCO
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@brian-brazil brian-brazil deleted the beorn7/route branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.