Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump Go dependencies #158

Merged
merged 1 commit into from Feb 14, 2020
Merged

Conversation

@simonpasquier
Copy link
Member

simonpasquier commented Feb 14, 2020

No description provided.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier simonpasquier requested a review from roidelapluie Feb 14, 2020
@roidelapluie

This comment has been minimized.

Copy link
Member

roidelapluie commented Feb 14, 2020

+249,219 −1,719

I want to understand it first. That a 100 factor.

@roidelapluie

This comment has been minimized.

Copy link
Member

roidelapluie commented Feb 14, 2020

Locally I have 83 files changed, 7061 insertions(+), 1708 deletions(-)

Copy link
Member

roidelapluie left a comment

Please clarify the file change. Locally I have

83 files changed, 7061 insertions(+), 1708 deletions(-)

@simonpasquier

This comment has been minimized.

Copy link
Member Author

simonpasquier commented Feb 14, 2020

Apparently most of the additions come from golang.org/x/sys which is an indirect dependency from github.com/prometheus/client_golang so this comes from prometheus/client_golang@5eb1c10.

The way I did it:

  • remove all modules that were indirect dependencies as there's no reason why we shouldn't trust how Go resolves module versions. I presume they've been added over time because 1) Go modules have different behavior between 1.11, 1.12 and 1.13 and 2) at the time, not all dependencies had migrated to Go modules.
  • manually updated the versions of github.com/prometheus/client_golang and github.com/hashicorp/consul/api to their latest.
  • go mod tidy.
@SuperQ
SuperQ approved these changes Feb 14, 2020
Copy link
Member

SuperQ left a comment

LGTM. We might want to look at pruning the indirect deps in other repos as well.

Copy link
Member

roidelapluie left a comment

thank you. I was missing go get -u github.com/prometheus/client_golang locally. somehow it was not picked up by go get -u ./....

@simonpasquier simonpasquier merged commit 1734a3e into prometheus:master Feb 14, 2020
4 checks passed
4 checks passed
DCO DCO
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-1.5 Your tests passed on CircleCI!
Details
ci/circleci: test-1.6 Your tests passed on CircleCI!
Details
@simonpasquier simonpasquier deleted the simonpasquier:bump-deps branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.