Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail with Go 1.18 due to denial of SHA1 certificates #83

Closed
jawn-smith opened this issue Mar 16, 2022 · 0 comments · Fixed by #105
Closed

Tests fail with Go 1.18 due to denial of SHA1 certificates #83

jawn-smith opened this issue Mar 16, 2022 · 0 comments · Fixed by #105

Comments

@jawn-smith
Copy link

This bug is present with commit hash 9f7b277 (latest master as of this writing).

Per the Go 1.18 release notes: "crypto/x509 will now reject certificates signed with the SHA-1 hash function. This doesn't apply to self-signed root certificates. Practical attacks against SHA-1 have been demonstrated since 2017 and publicly trusted Certificate Authorities have not issued SHA-1 certificates since 2015."

This is causing quite a few of the test cases to fail with Go 1.18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests with Go 1.18 simonpasquier/exporter-toolkit
1 participant
@jawn-smith