Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file_instances metric collector #205

Merged
merged 2 commits into from Jul 5, 2017
Merged

Fix file_instances metric collector #205

merged 2 commits into from Jul 5, 2017

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Jun 1, 2017

Include the event name column as a label for metrics gathered from performance_schema.file_summary_by_instance.

Default to not cleaning the path on performance_schema.file_summary_by_instance
names to avoid name colisions.

Closes: #203

Ben Kochie added 2 commits June 1, 2017 16:36
Include the event name column as a label for metrics gathered from
`performance_schema.file_summary_by_instance`.
Default to not cleaning the path on `performance_schema.file_summary_by_instance`
names to avoid name colisions.
@SuperQ
Copy link
Member Author

SuperQ commented Jun 1, 2017

CC @roman-vynar

@roman-vynar
Copy link
Contributor

I guess it came from @pskiwi originally.

@SuperQ
Copy link
Member Author

SuperQ commented Jun 1, 2017

Yup, I was hoping you could validate the sanity of the change.

@roman-vynar
Copy link
Contributor

@SuperQ looks good but something tells me that FILE_NAME+EVENT_NAME may not be enough or when removing the path prefix there could be still duplicates. Actually, it is hard to predict w/o running on real world systems :)

@SuperQ
Copy link
Member Author

SuperQ commented Jun 2, 2017

Yup, that's what I figured. This is why I'm disabling the path prefix feature by default now.

I'm thinking about removing the path prefix automatic removal and replacing this with a new flag. It would be something like remove_prefix="/var/lib/mysql/" and default to empty string. This way we can chop off redundancy in the path, while still making sure we're duplicate label safe.

@SuperQ SuperQ merged commit e755b01 into master Jul 5, 2017
@SuperQ SuperQ deleted the superq/file_instances branch August 18, 2017 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants