Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHOW GLOBAL VARIABLES metris #21

Merged
merged 1 commit into from Aug 26, 2015

Conversation

Projects
None yet
3 participants
@SuperQ
Copy link
Member

commented Aug 25, 2015

SHOW GLOBAL VARIABLES provides gauge-like views of various MySQL
internal tunable settings. These can be used for expressions that
compare current status (mysql_global_status_connections /
mysql_global_variables_max_connections)

@SuperQ

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2015

@roman-vynar This will give us all the metrics for SHOW GLOBAL VARIABLES.

@SuperQ SuperQ added this to the 1.0 milestone Aug 25, 2015

@SuperQ SuperQ force-pushed the superq/global_vars branch from 9ca2664 to ab0d13e Aug 25, 2015

@roman-vynar

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2015

That's great 👍

var globalVarValue sql.RawBytes

for globalVariablesRows.Next() {
globalVarKey = strings.ToLower(globalVarKey)

This comment has been minimized.

Copy link
@matthiasr

matthiasr Aug 25, 2015

Contributor

Why is this before the Scan? Seems like a NOOP here.

@matthiasr

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2015

👍 when the toLower is in the right spot

Add SHOW GLOBAL VARIABLES metris
SHOW GLOBAL VARIABLES provides gauge-like views of various MySQL
internal tunable settings.  These can be used for expressions that
compare current status (mysql_global_status_connections /
mysql_global_variables_max_connections)

@SuperQ SuperQ force-pushed the superq/global_vars branch from ab0d13e to 6a1e20a Aug 26, 2015

@SuperQ

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2015

@matthiasr Ahh, right, had it in the wrong place.

SuperQ added a commit that referenced this pull request Aug 26, 2015

@SuperQ SuperQ merged commit 80e4b7f into master Aug 26, 2015

@SuperQ SuperQ deleted the superq/global_vars branch Aug 26, 2015

SuperQ added a commit that referenced this pull request Aug 31, 2015

Cut 0.9.0 release
Includes many PRs:
* #10
* #12
* #14
* #15
* #17
* #19
* #20
* #21
* #22

@SuperQ SuperQ referenced this pull request Aug 31, 2015

Merged

Cut 0.3.0 release #24

SuperQ added a commit that referenced this pull request Aug 31, 2015

Cut 0.9.0 release
Includes many PRs:
* #10
* #12
* #14
* #15
* #17
* #19
* #20
* #21
* #22

SuperQ added a commit that referenced this pull request Aug 31, 2015

Cut 0.9.0 release
Includes many PRs:
* #10
* #12
* #14
* #15
* #17
* #19
* #20
* #21
* #22

SuperQ added a commit that referenced this pull request Aug 31, 2015

Cut 0.9.0 release
Includes many PRs:
* #10
* #12
* #14
* #15
* #17
* #19
* #20
* #21
* #22
* #25

SuperQ added a commit that referenced this pull request Aug 31, 2015

Cut 0.9.0 release
Includes many PRs:
* #10
* #12
* #14
* #15
* #17
* #19
* #20
* #21
* #22
* #25

arvenil pushed a commit to arvenil/mysqld_exporter that referenced this pull request Aug 30, 2018

Merge pull request prometheus#21 from percona/PMM-1753_keep_MySQL_con…
…nections_open_between_scrapes

PMM-1753: Keep MySQL connections open between scrapes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.