Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear last_scrape_error on every scrape #368

Merged
merged 1 commit into from Mar 3, 2019

Conversation

Projects
None yet
2 participants
@zstyblik
Copy link
Contributor

zstyblik commented Mar 2, 2019

Clear last_scrape_error on every scrape, otherwise last_scrape_error
remains to be set to 1 despite the fact issue which has caused the error
in the first place is gone.

Fixes #367

@zstyblik

This comment has been minimized.

Copy link
Contributor Author

zstyblik commented Mar 2, 2019

Hi,

is DCO thing mandatory?

@SuperQ

This comment has been minimized.

Copy link
Member

SuperQ commented Mar 2, 2019

Yes, DCO is mandatory per our contribution rules.

@zstyblik

This comment has been minimized.

Copy link
Contributor Author

zstyblik commented Mar 2, 2019

@SuperQ yeah, it was stupid question and I've realized seconds after posting it. I'll try to ... fix it :) Thanks.

@zstyblik zstyblik force-pushed the zstyblik:clear-last-scrape-error branch from b525905 to ee36c04 Mar 2, 2019

@SuperQ

This comment has been minimized.

Copy link
Member

SuperQ commented Mar 2, 2019

Would you mind adding an entry to the top of the CHANGELOG.md?

* [BUGFIX] Clear last_scrape_error on every scrape #368
Clear last_scrape_error on every scrape
Clear last_scrape_error on every scrape, otherwise last_scrape_error
remains to be set to 1 despite the fact issue which has caused the error
in the first place is gone.

Signed-off-by: Zdenek Styblik <stybla@turnovfree.net>

@zstyblik zstyblik force-pushed the zstyblik:clear-last-scrape-error branch from ee36c04 to d723d3f Mar 3, 2019

@zstyblik

This comment has been minimized.

Copy link
Contributor Author

zstyblik commented Mar 3, 2019

Would you mind adding an entry to the top of the CHANGELOG.md?

No problem. Like so? :)

EDIT: If I got too creative, I'll re-do it. My fault. ;|

@SuperQ

SuperQ approved these changes Mar 3, 2019

Copy link
Member

SuperQ left a comment

LGTM

@SuperQ SuperQ merged commit 1a91776 into prometheus:master Mar 3, 2019

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: codespell Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.