Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define consistent binary filename in promu configuration file #650

Merged
merged 1 commit into from Aug 22, 2017

Conversation

chriwill
Copy link
Contributor

Maintaining a fork with a different folder name breaks the travis build/test.

Sympton:

>> formatting code
>> vetting code
>> running staticcheck
>> building binaries
 >   prometheus-node-exporter
./ttar -C collector/fixtures -x -f collector/fixtures/sys.ttar
touch collector/fixtures/sys/.unpacked
>> running tests
ok  	github.com/prometheus/node_exporter	1.029s
ok  	github.com/prometheus/node_exporter/collector	1.068s
?   	github.com/prometheus/node_exporter/collector/ganglia	[no test files]
>> running end-to-end tests
./end-to-end-test.sh
./node_exporter not found. Consider running `go build` first.
make: *** [test-e2e] Error 1
The command "make" exited with 2.
Done. Your build exited with 1.

This pull request defines a consistent binary filename in the promu configuration file.

After applying this pull request:

>> building binaries
 >   node_exporter
./ttar -C collector/fixtures -x -f collector/fixtures/sys.ttar
touch collector/fixtures/sys/.unpacked
>> running tests
ok  	github.com/prometheus/node_exporter	1.508s
ok  	github.com/prometheus/node_exporter/collector	1.089s
?   	github.com/prometheus/node_exporter/collector/ganglia	[no test files]
>> running end-to-end tests
./end-to-end-test.sh
The command "make" exited with 0.
Done. Your build exited with 0.

Best Regards

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@discordianfish
Copy link
Member

LGTM, thanks!

@discordianfish discordianfish merged commit 2ed98fd into prometheus:master Aug 22, 2017
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants