Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mountstats: handle extended per-op stats #276

Merged
merged 1 commit into from Apr 11, 2020

Conversation

pgier
Copy link
Collaborator

@pgier pgier commented Mar 26, 2020

Linux 5.3 added a field to the per-operator NFS mount stats.
This change reads the extra field when it exists, and ignores
any additional fields which may be added in the future.

Fixes #275

Signed-off-by: Paul Gier pgier@redhat.com

Linux 5.3 added a field to the per-operator NFS mount stats.
This change reads the extra field when it exists, and ignores
any additional fields which may be added in the future.

Signed-off-by: Paul Gier <pgier@redhat.com>
@pgier pgier force-pushed the invalid-nfs-operations-stats branch from 5e653e4 to 19fa0fe Compare March 26, 2020 19:02
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 0f5e4f3 into prometheus:master Apr 11, 2020
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
Linux 5.3 added a field to the per-operator NFS mount stats.
This change reads the extra field when it exists, and ignores
any additional fields which may be added in the future.

Signed-off-by: Paul Gier <pgier@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mountstats error: invalid NFS per-operations stats
4 participants