Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upHashMod sum64 foobar #1004
Comments
This comment has been minimized.
This comment has been minimized.
|
Wouldn't a XOR have bad distribution properties as well? If you just switch the position of some of the input bytes, the output hash will be the same. Basically, any permutation of the input bytes will produce the same output :) |
This comment has been minimized.
This comment has been minimized.
|
Ah I read you wrong. You want to XOR the hash, not the input. |
This comment has been minimized.
This comment has been minimized.
|
yes, xor that hashed bytes. |
miekg
closed this
Aug 19, 2015
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
miekg commentedAug 18, 2015
This
shiftthat I added is wrong :(https://github.com/prometheus/prometheus/blob/master/retrieval/relabel.go#L88
It shifts too much, discarding much of the glorious hash input. If have a PR almost ready to just do a simple xor of all the hash bytes, which looks simpler and works better. Finishing the last bit in the tests.