Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation rules order of evaluation undefined #1088

Closed
aecolley opened this Issue Sep 16, 2015 · 6 comments

Comments

Projects
None yet
5 participants
@aecolley
Copy link

aecolley commented Sep 16, 2015

It is impossible to use a recorded value in another recorded rule, because the evaluation order is unpredictable. Sometimes, you get the value from the current evaluation, and sometimes you get the result of the previous evaluation. This leads to oddities like dividing this minute's sum1m by last minute's count1m, giving wrong values and the occasional +Inf.

Suggested fix: add a command-line flag to enforce sequential evaluation of rules in the same order as their appearance in the rules file.

This is related to issue 17, but that is about adopting some sophisticated automatic sorting, whereas this bug is about the lack of any basic consistency. I would be unhappy if this wasn't going to be fixed until issue 17 was ready.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Sep 16, 2015

The agreed solution is to be able to have groups of rules, and that they will be ordered within the group. This still allows use of multiple cores for calculations.

I suspect that #17 will never happen.

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Sep 17, 2015

Should we create a new issue that describes the preferred approach, and close this and #17 ?
@juliusv What do you think?

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Sep 17, 2015

👍

On Thu, Sep 17, 2015 at 6:42 PM Björn Rabenstein notifications@github.com
wrote:

Should we create a new issue that describes the preferred approach, and
close this and #17 #17 ?
@juliusv https://github.com/juliusv What do you think?


Reply to this email directly or view it on GitHub
#1088 (comment)
.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Sep 17, 2015

👍 Will do.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Sep 17, 2015

Superseded by #1095. Closing.

@juliusv juliusv closed this Sep 17, 2015

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.