Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text format parser ignoring EOF format error #1135

Closed
zeroware opened this Issue Oct 2, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@zeroware
Copy link

zeroware commented Oct 2, 2015

I wrote a custom exporter and forgot to add a line return \n at the end of the file.
Prometheus displayed that my target was healthy but my metrics were not parsed.

This is low priority but we should have some kind of error message.

Note : previous versions of prometheus returned an EOF error.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Oct 2, 2015

That is probably caused by the new decoder, which in theory supports
streaming. EOF is a signal that the stream is done.
If it happens while parsing a metric, I think the underlying parser should
explicitly state that it is a premature EOF.

On Fri, Oct 2, 2015, 8:24 AM Zero notifications@github.com wrote:

I wrote a custom exporter and forgot to add a line return \n at the end
of the file.
Prometheus displayed that my target was healthy but my metrics were not
parsed.

This is low priority but we should have some kind of error message.

Note : previous versions of prometheus returned an EOF error.


Reply to this email directly or view it on GitHub
#1135.

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Feb 11, 2016

Needs updated vendoring to take effect in head.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.