Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus should continue to bootstrap go #1136

Closed
StephanErb opened this Issue Oct 2, 2015 · 13 comments

Comments

Projects
None yet
5 participants
@StephanErb
Copy link
Contributor

StephanErb commented Oct 2, 2015

Prometheus 15.x used to download go when one was calling make, if go was not installed. The latest rc does no longer do that. For me as an end user, this feels like a regression.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Oct 2, 2015

What we have done before does no longer work with the official vendoring proposal coming with Go 1.5, which ultimately has features we will need.
The Go tool was actively working against what we have done before – it was merely a hole our approach slipped through and made it work. The Go tool is simply not meant to be used that way. It strongly expects a proper setup of a $GOPATH.
The alternative would have been for make to heavily alter your folder structure underneath itself, which is not what a user wants it to do either.

@brian-brazil will agree with you, though.
Personally, I strongly think that setting up a compile environment should never be part of an application's build process. Especially for Go which is as trivial to setup as any interpreter.
Nobody would expect a python or npm package to download and install an interpreter. Everyone is perfectly fine with doing brew install npm before (or equivalent). For Go it is brew install go.

There is hope though. The scripts/goenv.sh script downloads and installs a Go environment for you.
You have to care about setting up a correct folder structure the compiler can work with, though.

It should go something like this. As you can see, just doing a proper Go installation might turn out to be easier.

export dir=$HOME/gopath/src/github.com/prometheus/prometheus
mkdir -p $HOME/go $dir
source ./scripts/goenv.sh $HOME/go $dir
cp -r ./* $dir/
cd $dir
make

We also provide pre-built binaries.

@StephanErb

This comment has been minimized.

Copy link
Contributor Author

StephanErb commented Oct 2, 2015

I have totally missed that you provide pre-built binaries. They solve the hurdles for me as a enduser. Thanks for your quick reaction!

@StephanErb StephanErb closed this Oct 2, 2015

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Oct 2, 2015

They admittedly lack visibility on our site and in the repo's README.

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Oct 2, 2015

We definitely need very visible pointers to binaries and Debian packages everywhere. Official deb's are in Stretch testing. And then there is Brian's stuff.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Oct 2, 2015

Not sure I understand, binaries are pointed out under http://prometheus.io/docs/introduction/install/ and https://github.com/prometheus/prometheus/#precompiled-binaries already? Also in http://prometheus.io/docs/introduction/getting_started/.

The debs could be pointed out more, but we don't have ones yet that belong to the project itself, but maybe point to the official Debian and/or Brian ones?

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Oct 2, 2015

Yes, but it is hidden in text. I guess some big download buttons would be helpful.
That's the first thing I look for when visiting the website of a project I want to try out.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Oct 2, 2015

Ah ok - yeah, all for putting it on the frontpage somewhere :)

@barkerd427

This comment has been minimized.

Copy link

barkerd427 commented Oct 2, 2015

Big buttons definitely help. I didn't find them right away either. Chef has
a nice layout for downloads.
On Oct 2, 2015 08:39, "Julius Volz" notifications@github.com wrote:

Ah ok - yeah, all for putting it on the frontpage somewhere :)


Reply to this email directly or view it on GitHub
#1136 (comment)
.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Oct 8, 2015

Working on a "Download" frontpage button. The question is, we already list different download options on http://prometheus.io/docs/introduction/install/, but I think it might make sense to have a dedicated page just for downloading, similar to http://grafana.org/download/. Maybe even link it like that from the top nav as a button like in Grafana? I'm generally against overloading the top nav, but that might be worth it, and stylistically, it stands out enough from the rest of the menu in the right way, IMO.

@barkerd427

This comment has been minimized.

Copy link

barkerd427 commented Oct 9, 2015

That would be helpful. Thank you.
On Oct 8, 2015 8:22 AM, "Julius Volz" notifications@github.com wrote:

Working on a "Download" frontpage button. The question is, we already list
different download options on
http://prometheus.io/docs/introduction/install/, but I think it might
make sense to have a dedicated page just for downloading, similar to
http://grafana.org/download/. Maybe even link it like that from the top
nav as a button like in Grafana? I'm generally against overloading the top
nav, but that might be worth it, and stylistically, it stands out enough
from the rest of the menu in the right way, IMO.


Reply to this email directly or view it on GitHub
#1136 (comment)
.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Oct 9, 2015

Heh - of course Prometheus is a bit more complicated in the respect that it has a many components we offer downloads for (and in different ways), so will have to think a bit how to structure that.

@barkerd427

This comment has been minimized.

Copy link

barkerd427 commented Oct 9, 2015

Just getting a dedicated download page with a button on the front page will
be a huge improvement. Set the Prometheus binaries at the top with download
buttons or a selector of some type. The other components could just be
links to the current docs for the first iteration. I'm more likely to
upgrade Prometheus than the other pieces.
On Oct 9, 2015 7:19 AM, "Julius Volz" notifications@github.com wrote:

Heh - of course Prometheus is a bit more complicated in the respect that
it has a many components we offer downloads for (and in different ways), so
will have to think a bit how to structure that.


Reply to this email directly or view it on GitHub
#1136 (comment)
.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.