Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-completion getting in the way of BY clause #1185

Closed
fabxc opened this Issue Oct 27, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@fabxc
Copy link
Member

fabxc commented Oct 27, 2015

When adding a label to a by-clause and hitting enter to execute the query the first auto-completion entry is added.
Either labels should be suggested or nothing.

@fabxc

This comment has been minimized.

Copy link
Member Author

fabxc commented Oct 27, 2015

Extending this – we should block auto-completion for anything with leading digits, also known as numbers.

As pointed out by @grobie there is no longer a way to see a list of all metric names since we removed the respective dropdown menu. I suggest those be shown when hitting the down button without any preceeding non-whitespace input.

This leads to the point of multiline input. Currently navigating through multiple lines is blocked by the auto-suggest dropdown. We should provide some reasonably intuitive way around this, e.g. disabling auto-completion while holding CTRL.

@fabxc

This comment has been minimized.

Copy link
Member Author

fabxc commented Oct 28, 2015

CTRL+Z does ignore metric names inserted via auto-completion.

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Feb 5, 2016

Auto complete was reverted for now in #1303.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.