Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Exporter for Spring Boot Metrics #1190

Closed
mingfang opened this Issue Oct 29, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@mingfang
Copy link

mingfang commented Oct 29, 2015

Spring Boot applications by default supports the /metrics endpoint exposing JVM and application metrics, http://docs.spring.io/spring-boot/docs/current/reference/html/production-ready-metrics.html

However the response is not compatible with Prometheus.
I know about the JMX Exporter but it would be great to have an official SpringBootExporter that works out of the box.

@jimmidyson

This comment has been minimized.

Copy link
Member

jimmidyson commented Oct 29, 2015

👍 I've made a start but it's stalled a bit due to other things. See https://github.com/jimmidyson/spring-boot-prometheus - really happy for contributions to get it working nicely.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Oct 29, 2015

The general idea would be to write a simpleclient collector that'd proxy the metrics, giving them good labels where possible.

I note that Spring counters are not compatible with Prometheus counters, as they have a decrement method.

@jimmidyson

This comment has been minimized.

Copy link
Member

jimmidyson commented Oct 29, 2015

I had to use a Prometheus gauge in place of spring counters. Was going to do the same as dropwizard spring metrics implementation & use metrics prefixes to create counters & summaries as required.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Dec 16, 2015

There's nothing to be done here on the Prometheus side, if there's anything on the client_java side please open up an issue there.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.