Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDefault to now if time paramater not specified in HTTP API #1207
Comments
This comment has been minimized.
This comment has been minimized.
|
If people are worried about this being used incorrectly by accident, we could also use something like |
This comment has been minimized.
This comment has been minimized.
|
I think making it optional would make sense. |
This comment has been minimized.
This comment has been minimized.
|
Or Making it optional is very implicit. If I say |
This comment has been minimized.
This comment has been minimized.
|
I'd expect that most users are doing quick lookups the same as in the expression browser and would like things to just work. In that context I'm not seeing much benefit to having them specify an additional magic parameter. |
This comment has been minimized.
This comment has been minimized.
|
Inserting it without any indicator is more magic. It's almost zero effort to do. |
This comment has been minimized.
This comment has been minimized.
|
I don't consider default parameters to be magic. It's a common approach in both HTTP parameters as well as programming functions. The used timestamp will be visible in the result and how to set a timestamp explicitly can be seen in the documentation. |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
So be it then :) On Wed, Nov 11, 2015 at 7:29 PM Jimmi Dyson notifications@github.com
|
grobie
closed this
in
#1211
Nov 12, 2015
This comment has been minimized.
This comment has been minimized.
|
Thanks all. |
brian-brazil
referenced this issue
Nov 13, 2015
Closed
Document optional time parameter for API #260
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
qed- commentedNov 10, 2015
As discussed here: https://groups.google.com/forum/#!topic/prometheus-developers/JrU8l0-IKt8 it would be convenient if the GET /api/v1/query endpoint defaulted to 'now' if the time paramater is not specified.
Use case is to allow a client to get the current state of metrics without worrying about clock sync, staleness handling.