Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts page should display expanded ANNOTATIONS #1219

Closed
matthiasr opened this Issue Nov 13, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@matthiasr
Copy link
Contributor

matthiasr commented Nov 13, 2015

Even though the expansion happens in Prometheus, it is only visible in Alertmanager. It should be available on /alerts.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Nov 14, 2015

I think this should be available as debug information, but not displayed by default. Displaying all payloads could get very cluttered.

@matthiasr

This comment has been minimized.

Copy link
Contributor Author

matthiasr commented Nov 14, 2015

Agree.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Apr 30, 2016

This issue is about the display of alerts in the Prometheus UI and a
different concern than what you describe.

Your annotations are about a single alert. A notification as the one you've
shown for Slack is about N alerts. Thus it often has N different
descriptions.

Especially notification integrations with short messages like Slack oder
PagerDuty are a first point of contact and should be short. Labels are the
most information dense for this puropose. More elaborate information is
generally one click away.
That said, you can make it more descriptive via Alertmanagers templating if
you like.

On Fri, Apr 29, 2016, 10:11 PM SleepyBrett notifications@github.com wrote:

Disagree strongly. When scraping a Kubernetes cluster and alerting out to
Slack, the title of the alert is a blob of label values stuffed together.
It looks like this:

[FIRING:1] DiskFilling (us-west-2a i-xxxxx m4.large us-west-2 subnet-xxx
m4.large /dev/xvda9 us-west-2 us-west-2a /
ip-xxxx.us-west-2.compute.internal kubernetes-cluster ip-xxx.net node
critical)

This is only useful if I examine it very deeply. However in an annotation
I've provided a friendly message:

description="Disk {{ $labels.device }} on host {{ $labels.instance }} ({{
$labels.aws_amazon_com_instance_id }}) is filling up. Disk is {{ $value }}
full at the time of alerting."

That is a meaningful alert to wake someone up with a page.

IMO labels, while an important way to do routing are not appropriate for
end users except as additional information. I want an actionable and
meaningful "alert title".


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1219 (comment)

@brian-brazil brian-brazil changed the title Alerts page should display expanded SUMMARY/DESCRIPTION resp. ANNOTATIONS Alerts page should display expanded ANNOTATIONS Oct 26, 2016

roidelapluie added a commit to roidelapluie/prometheus that referenced this issue Mar 1, 2018

Display annotations on Alerts page
Fixes prometheus#1219

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>

brian-brazil added a commit that referenced this issue Mar 1, 2018

Display annotations on Alerts page (#3900)
Fixes #1219

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>

iobestar pushed a commit to iobestar/prometheus that referenced this issue Apr 10, 2018

Display annotations on Alerts page (prometheus#3900)
Fixes prometheus#1219

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>

sipian pushed a commit to sipian/prometheus that referenced this issue May 18, 2018

Display annotations on Alerts page (prometheus#3900)
Fixes prometheus#1219

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Signed-off-by: sipian <cs15btech11019@iith.ac.in>

bobmshannon pushed a commit to bobmshannon/prometheus that referenced this issue Nov 19, 2018

Display annotations on Alerts page (prometheus#3900)
Fixes prometheus#1219

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.