Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate label names upon ingestion. #1232

Closed
beorn7 opened this Issue Nov 20, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@beorn7
Copy link
Member

beorn7 commented Nov 20, 2015

It appears the server will happily ingest metrics with invalid labelnames.

@jpittis

This comment has been minimized.

Copy link

jpittis commented Nov 20, 2015

I can get to this next week.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Nov 30, 2015

As discussed offline this should be fixed in common/expfmt and is only an issue for the protobuf protocol

fabxc added a commit that referenced this issue Dec 10, 2015

fabxc added a commit that referenced this issue Jan 11, 2016

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.