Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider length limit for label values on ingestion #1235

Closed
brian-brazil opened this Issue Nov 24, 2015 · 3 comments

Comments

Projects
None yet
5 participants
@brian-brazil
Copy link
Member

brian-brazil commented Nov 24, 2015

We could end up with such a long labelvalue that it causes performance issues (e.g. if a metric was split out by a user-provided customer name). It might be an idea to have a limit on how long a label value can be, defaulting to something like 1KiB.

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Nov 24, 2015

I'm against an arbitrary limit. While label values could become too long accidentally, I'm sure somebody will be able to come up with a legitimate use-case for any label value length eventually.

Obviously, we are “vulnerable” to abusive clients, but we are that anyway. E.g. it's very easy to create millions of time series in a very short time and bring down the server. The responsibility of not overloading the server lies with the client.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Jul 23, 2016

I think I'm with @beorn7 on this one. Should we close it?

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.