Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upConsider length limit for label values on ingestion #1235
Comments
This comment has been minimized.
This comment has been minimized.
|
I'm against an arbitrary limit. While label values could become too long accidentally, I'm sure somebody will be able to come up with a legitimate use-case for any label value length eventually. Obviously, we are “vulnerable” to abusive clients, but we are that anyway. E.g. it's very easy to create millions of time series in a very short time and bring down the server. The responsibility of not overloading the server lies with the client. |
brian-brazil
added
the
feature-request
label
Dec 16, 2015
fabxc
added
kind/enhancement
and removed
feature request
labels
Apr 28, 2016
This comment has been minimized.
This comment has been minimized.
|
I think I'm with @beorn7 on this one. Should we close it? |
grobie
closed this
Jul 24, 2016
pjanotti
referenced this issue
Mar 13, 2019
Open
exporter/prometheusexporter: migrate code in here #479
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
brian-brazil commentedNov 24, 2015
We could end up with such a long labelvalue that it causes performance issues (e.g. if a metric was split out by a user-provided customer name). It might be an idea to have a limit on how long a label value can be, defaulting to something like 1KiB.