Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests to web UI #125

Open
discordianfish opened this Issue Apr 9, 2013 · 6 comments

Comments

Projects
None yet
6 participants
@discordianfish
Copy link
Member

discordianfish commented Apr 9, 2013

Let's figure out what we can use.

ie.:

@matttproud

This comment has been minimized.

Copy link
Member

matttproud commented Apr 9, 2013

👍

@fabxc fabxc added kind/enhancement and removed enhancement labels Apr 28, 2016

@mattbostock

This comment has been minimized.

Copy link
Contributor

mattbostock commented Apr 17, 2017

I'd recommend Agouti, a webdriver client for Go:
http://agouti.org/#using-agouti-by-itself

Here are some examples tests I've written using Agouti:
https://github.com/mattbostock/leavediary/blob/a8eaf858c2b941773a471e7fc76b2f43aaa9e26c/acceptance_test.go#L74

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Apr 17, 2017

Actually, I think we should separate the UI from the server (depends on #2467) and do the testing solely in javascript. There are proposals to rewrite the UI in Elm following the current alertmanager rewrite.

@mattbostock

This comment has been minimized.

Copy link
Contributor

mattbostock commented Apr 17, 2017

@grobie: Can you expand on what you mean by separating the UI from the server? Do you mean the UI will be entirely rendered using javascript, which connects to the API backend?

I think I mistook the intent of this issue to be 'acceptance tests', i.e. blackbox verification of common user journeys. Completely agree on testing the javascript side in isolation. Perhaps those might be covered as part of the work on integration testing: #1106

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Apr 17, 2017

@discordianfish

This comment has been minimized.

Copy link
Member Author

discordianfish commented Apr 18, 2017

Agreed, and I've actually gained some experience recently with this. So if someone needs help setting up the frontend tests, let me know.

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

Merge pull request prometheus#125 from prometheus/grobie-patch-1
Add Jamie Wilkinson's  Monitorama workshop to media
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.