Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upprometheus_local_storage_chunks_to_persist includes #1323
Comments
beorn7
added
the
bug
label
Jan 17, 2016
beorn7
self-assigned this
Jan 17, 2016
This comment has been minimized.
This comment has been minimized.
|
Once this is fixed, we probably want to change the heuristics for going into "graceful degradation mode". If the number of memory chunks exceeds the configured amount and there is a reasonable (but not necessarily large) number of chunks waiting for persistence, we should also go into "speedy" mode. |
This comment has been minimized.
This comment has been minimized.
|
How soon can we fix these related issues? |
This comment has been minimized.
This comment has been minimized.
|
This is pretty low hanging fruit. I'll fix it ~this week. |
beorn7
referenced this issue
Jan 25, 2016
Merged
Fix multiple issues around chunks to persist. #1345
beorn7
closed this
in
#1345
Jan 26, 2016
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
beorn7 commentedJan 17, 2016
chunksToPersist in function loadSeriesMapAndHeads is incremented for every chunk read from the snapshot. even if it is a still open head chunk. That overestimates the number of chunks to persist