Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/ui/bindata.go changes during runtime #1326

Closed
RichiH opened this Issue Jan 18, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@RichiH
Copy link
Member

RichiH commented Jan 18, 2016

If I want to git pull in a repo I also build & run from, I always get

error: Your local changes to the following files would be overwritten by checkout:
        web/ui/bindata.go
Please, commit your changes or stash them before you can switch branches.
Aborting

I am unsure if said file should not be tracked at all or if local state should be put elsewhere, but either way, this is annoying.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Jan 18, 2016

It doesn't change at runtime – at least there's would be no logical cause for that.

It most likely happens when you run make and the assets target is executed. It always wants to update all the timestamps. Best to remove that from the default execution.

@RichiH

This comment has been minimized.

Copy link
Member Author

RichiH commented Jan 18, 2016

fabxc added a commit that referenced this issue Jan 18, 2016

Remove `assets` target from default `make` execution
go-bindata constantly attempts to update timestamps even though
the file data didn't change.

Fixes #1326
@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Jan 18, 2016

I agree that it's truly annoying. We removed it from Alertmanager for that reason but didn't do for Prometheus yet.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.