Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTiming issues in storage test #1337
Comments
This comment has been minimized.
This comment has been minimized.
|
Built and tested node_exporter, blackbox_exporter, and Grafana; I guess it's really Prometheus. |
This comment has been minimized.
This comment has been minimized.
|
This looks like a race condition, hopefully only in the test code. Do you get this every time? |
grobie
changed the title
Error during build
Panic in notification test
Jan 22, 2016
This comment has been minimized.
This comment has been minimized.
|
I get it every time, but with different output. That would support the race condition. Note that his hardware is faster than the Raspi someone uses, but slower than pretty much anything people would ever use for Prometheus elsewhere. Need more pastes? |
This comment has been minimized.
This comment has been minimized.
|
Data point: Full CPU load or no other load, the test errors out. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
I'm looking into the notification panic. @beorn7 The second test output is storage related. I guess both cases are timing issues in the tests and thus not critical but if maybe they are easy to fix. |
This comment has been minimized.
This comment has been minimized.
|
@RichiH As far as the notification test goes my first suspect would be that the timeout is too short for a slow machine, which causes a race with the I pushed the |
This comment has been minimized.
This comment has been minimized.
|
Happened one time out of three
Return code 2 |
This comment has been minimized.
This comment has been minimized.
|
That's the storage test failure. Did the panic of the notification test happen again as well? |
This comment has been minimized.
This comment has been minimized.
|
Nope,that's gone.
Richard
Sent by mobile; excuse my brevity.
|
fabxc
changed the title
Panic in notification test
Timing issues in storage test
Jan 26, 2016
This comment has been minimized.
This comment has been minimized.
fabxc
assigned
beorn7
Jan 26, 2016
beorn7
added
the
bug
label
Jan 26, 2016
beorn7
referenced this issue
Mar 3, 2016
Merged
Give TestEvictAndLoadChunkDescs more time to actually evict #1454
This comment has been minimized.
This comment has been minimized.
|
Can we close this off? I see no relevant breakages (just that 386 compiler issue) on my build server in the past month. |
This comment has been minimized.
This comment has been minimized.
|
How about we still merge #1454 ? It's only increasing one of the nasty sleep times. Would be much better to get rid of those altogether, but that will be quite an effort. |
This comment has been minimized.
This comment has been minimized.
|
@fabxc just merged it. So I'm closing this. Please re-open if new evidence shows up. |
beorn7
closed this
Apr 8, 2016
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
RichiH commentedJan 22, 2016
This is a new machine, PC Engines Apu2b4, so I can't say for sure if local disk and RAM are OK. I do not have any indication that this is not the case and the RAM has ECC, though.