Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upStorage: Change Append(*Sample) method to return error #1356
Comments
beorn7
added
the
enhancement
label
Jan 28, 2016
beorn7
referenced this issue
Jan 29, 2016
Merged
Rework the way to communicate backpressure (AKA suspended ingestion) #1354
beorn7
assigned
beorn7 and
fabxc
and unassigned
beorn7
Feb 1, 2016
fabxc
closed this
Feb 3, 2016
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
beorn7 commentedJan 28, 2016
After some discussion: Things that are not highly irregular (and not a programming error) can lead to samples not being ingested (most prominently out-of-order samples). Dealing with that should be done by the caller (even if it is only logging \ at least the logging can be coalesced; also we might to declare the scrape invalid and set
upto 0 if some samples weren't ingested properly).