Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rate() to be per-second again #136

Closed
juliusv opened this Issue Apr 12, 2013 · 2 comments

Comments

Assignees

@juliusv juliusv

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@juliusv
@juliusv
Copy link
Member

juliusv commented Apr 12, 2013

ec41345 introduced a regression in

prometheus/rules/ast/functions.go

Line 123 in 6cb3c51

sample.Value /= model.SampleValue(interval / time.Second)
. Since samples in vectors are no longer pointers, the per-second rate adjustment in rateImpl() is applied to the result vector. Fix this and add a test!

@ghost ghost assigned juliusv Apr 12, 2013

@juliusv

This comment has been minimized.

Sign in to view
Copy link
Member Author

juliusv commented Apr 12, 2013

/cc @bernerdschaefer @peterbourgon

@juliusv juliusv referenced this issue Apr 15, 2013

Merged

Fix rate() per-second adjustment. #145

@juliusv juliusv closed this Apr 15, 2013

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

@juliusv
Merge pull request prometheus#136 from kbudde/patch-1 
Update exporters.md
5b6f734
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 25, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.