Fail to start when a system hostname contains _

[roman-vynar]

Prometheus fails to start silently when a system hostname contains _:

[root@centos6 ~]# hostname my_server
[root@centos6 ~]# /var/lib/prometheus/prometheus 
[root@centos6 ~]# strace /var/lib/prometheus/prometheus 
...
...
...
openat(AT_FDCWD, "/proc/sys/kernel/hostname", O_RDONLY|O_CLOEXEC) = 3
read(3, "my_server\n", 512)             = 10
close(3)                                = 0
mmap(0xc820200000, 1048576, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0xc820200000
mmap(0xc81ffe8000, 32768, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0xc81ffe8000
exit_group(2)                           = ?
+++ exited with 2 +++
[root@centos6 ~]# 

[fabxc]

Thanks for reporting – this shouldn't fail silently. We simply missed to log the error (underscores in hostnames are not valid).

[roman-vynar]

Thanks for quick reaction 👍

[pondix]

Awesome!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.