Use tls config code in common

[brian-brazil]

prometheus/common#31 copied the tls config code over to common so it could be shared with the blackbox exporter. We should switch prometheus over to use this too for consistency. It's likely the alertmanager will also end up using this for webhook and/or HA.

[fabxc]

I'm not 100% confident yet that this is something where shared code is the
best solution.

This will spread out into sharing code for a lot a similar small things up
to a point where things become unnecessarily static.

On Sun, Feb 28, 2016, 8:00 PM Brian Brazil notifications@github.com wrote:

prometheus/common#31 prometheus/common#31
copied the tls config code over to common so it could be shared with the
blackbox exporter. We should switch prometheus over to use this too for
consistency. It's likely the alertmanager will also end up using this for
webhook and/or HA.

—
Reply to this email directly or view it on GitHub
#1430.

[brian-brazil]

I'm planning on sharing all the auth&ssl code for http as I'm expecting an identical need across 3 repos. Having separate copies would lead to divergence.

I'm not seeing anything else that could be shared currently.

[fabxc]

Factoring out code to common packages can make sense of course but should
happen more carefully.

The referenced PR factors out code from two packages with significant
design issues into a single shared one.

It's easy to say that we can always change it - but that's not reality with
these things.

On Sun, Feb 28, 2016, 9:01 PM Brian Brazil notifications@github.com wrote:

I'm planning on sharing all the auth&ssl code for http as I'm expecting an
identical need across 3 repos. Having separate copies would lead to
divergence.

I'm not seeing anything else that could be shared currently.

—
Reply to this email directly or view it on GitHub
#1430 (comment)
.

[fabxc]

And not seeing anything currently is not the issue - with the next thing
remotely similar that's used more than once it will be "this is a perfect
fit for that common package".

On Sun, Feb 28, 2016, 9:19 PM Fabian Reinartz fab.reinartz@gmail.com
wrote:

Factoring out code to common packages can make sense of course but should
happen more carefully.

The referenced PR factors out code from two packages with significant
design issues into a single shared one.

It's easy to say that we can always change it - but that's not reality
with these things.

On Sun, Feb 28, 2016, 9:01 PM Brian Brazil notifications@github.com
wrote:

I'm planning on sharing all the auth&ssl code for http as I'm expecting
an identical need across 3 repos. Having separate copies would lead to
divergence.

I'm not seeing anything else that could be shared currently.

—
Reply to this email directly or view it on GitHub
#1430 (comment)
.

[skebo]

+1 for use of common code for auth&ssl for http. my specific use case is marathon with basic authentication.

[brian-brazil]

This was done.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.