Race conditions in retrieval

[beorn7]

At commit e83f05f (but surely introduced earlier, just for line number reference).

==================
WARNING: DATA RACE
Read by goroutine 116:
  github.com/prometheus/prometheus/retrieval.(*scrapePool).sync()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/scrape.go:227 +0x408
  github.com/prometheus/prometheus/retrieval.(*targetSet).sync()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:258 +0x2b6
  github.com/prometheus/prometheus/retrieval.(*targetSet).runProviders()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:331 +0x41b
  github.com/prometheus/prometheus/retrieval.(*TargetManager).reload()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:124 +0x31c
  github.com/prometheus/prometheus/retrieval.(*TargetManager).Run()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:79 +0x243

Previous write by goroutine 59:
  github.com/prometheus/prometheus/retrieval.(*targetSet).runScraping()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:227 +0xe9
  github.com/prometheus/prometheus/retrieval.(*TargetManager).reload.func1()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:118 +0x67
==================



==================
WARNING: DATA RACE
Read by goroutine 116:
  github.com/prometheus/prometheus/vendor/golang.org/x/net/context.(*cancelCtx).Done()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/vendor/golang.org/x/net/context/context.go:304 +0x33
  github.com/prometheus/prometheus/vendor/golang.org/x/net/context.propagateCancel()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/vendor/golang.org/x/net/context/context.go:227 +0x38
  github.com/prometheus/prometheus/vendor/golang.org/x/net/context.WithCancel()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/vendor/golang.org/x/net/context/context.go:213 +0x276
  github.com/prometheus/prometheus/retrieval.newScrapeLoop()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/scrape.go:379 +0x1a3
  github.com/prometheus/prometheus/retrieval.(*scrapePool).sync()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/scrape.go:227 +0x495
  github.com/prometheus/prometheus/retrieval.(*targetSet).sync()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:258 +0x2b6
  github.com/prometheus/prometheus/retrieval.(*targetSet).runProviders()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:331 +0x41b
  github.com/prometheus/prometheus/retrieval.(*TargetManager).reload()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:124 +0x31c
  github.com/prometheus/prometheus/retrieval.(*TargetManager).Run()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:79 +0x243

Previous write by goroutine 59:
  github.com/prometheus/prometheus/vendor/golang.org/x/net/context.WithCancel()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/vendor/golang.org/x/net/context/context.go:212 +0x1fc
  github.com/prometheus/prometheus/retrieval.(*targetSet).runScraping()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:225 +0x4d
  github.com/prometheus/prometheus/retrieval.(*TargetManager).reload.func1()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:118 +0x67
==================


==================
WARNING: DATA RACE
Write by goroutine 116:
  sync/atomic.CompareAndSwapInt32()
      /usr/local/go/src/runtime/race_amd64.s:279 +0xb
  sync.(*Mutex).Lock()
      /usr/local/go/src/sync/mutex.go:44 +0x4d
  github.com/prometheus/prometheus/vendor/golang.org/x/net/context.propagateCancel()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/vendor/golang.org/x/net/context/context.go:231 +0x97
  github.com/prometheus/prometheus/vendor/golang.org/x/net/context.WithCancel()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/vendor/golang.org/x/net/context/context.go:213 +0x276
  github.com/prometheus/prometheus/retrieval.newScrapeLoop()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/scrape.go:379 +0x1a3
  github.com/prometheus/prometheus/retrieval.(*scrapePool).sync()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/scrape.go:227 +0x495
  github.com/prometheus/prometheus/retrieval.(*targetSet).sync()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:258 +0x2b6
  github.com/prometheus/prometheus/retrieval.(*targetSet).runProviders()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:331 +0x41b
  github.com/prometheus/prometheus/retrieval.(*TargetManager).reload()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:124 +0x31c
  github.com/prometheus/prometheus/retrieval.(*TargetManager).Run()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:79 +0x243

Previous write by goroutine 59:
  github.com/prometheus/prometheus/vendor/golang.org/x/net/context.WithCancel()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/vendor/golang.org/x/net/context/context.go:212 +0x1fc
  github.com/prometheus/prometheus/retrieval.(*targetSet).runScraping()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:225 +0x4d
  github.com/prometheus/prometheus/retrieval.(*TargetManager).reload.func1()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:118 +0x67
==================


==================
WARNING: DATA RACE
Read by goroutine 60:
  github.com/prometheus/prometheus/vendor/golang.org/x/net/context.(*cancelCtx).Deadline()
      <autogenerated>:7 +0x5a
  github.com/prometheus/prometheus/vendor/golang.org/x/net/context.(*cancelCtx).Deadline()
      <autogenerated>:7 +0x80
  github.com/prometheus/prometheus/vendor/golang.org/x/net/context.WithDeadline()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/vendor/golang.org/x/net/context/context.go:352 +0x6a
  github.com/prometheus/prometheus/vendor/golang.org/x/net/context.WithTimeout()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/vendor/golang.org/x/net/context/context.go:419 +0x11a
  github.com/prometheus/prometheus/retrieval.(*scrapeLoop).run()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/scrape.go:409 +0x365

Previous write by goroutine 59:
  github.com/prometheus/prometheus/vendor/golang.org/x/net/context.WithCancel()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/vendor/golang.org/x/net/context/context.go:212 +0x1fc
  github.com/prometheus/prometheus/retrieval.(*targetSet).runScraping()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:225 +0x4d
  github.com/prometheus/prometheus/retrieval.(*TargetManager).reload.func1()
      /home/bjoern/gocode/src/github.com/prometheus/prometheus/retrieval/targetmanager.go:118 +0x67

Let me know if you want the "createt at" parts, too.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.